AC power source amplitude fix #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KrzysztofHerman <[email protected]>
|
@ra3xdh indeed, it considers the voltage divider on the ideally matched network so the previous fix is the correct one. Shall I fix only the string in the properties window? |
|
Yes, modify the PR. |
Signed-off-by: KrzysztofHerman <[email protected]>
Signed-off-by: KrzysztofHerman <[email protected]>
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix two issues:
AC POWER SOURCErelated to the power field. It changesWattstodBmngspiceandXycespecification a voltage amplitude is required. Seengspicemanual:Example from the figure above: